Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-24.3.0-rc: kv: print traced query when failing the TestProxyTracing #136108

Merged
merged 3 commits into from
Nov 25, 2024
Merged

release-24.3.0-rc: kv: print traced query when failing the TestProxyTracing #136108

merged 3 commits into from
Nov 25, 2024

Conversation

iskettaneh
Copy link
Contributor

@iskettaneh iskettaneh commented Nov 25, 2024 •
edited
Loading

Backport 3/3 commits from #135846, #135858, #135921.

/cc @cockroachdb/release

This commit prints the traced query when TestProxyTracing test fails. This should help with debugging the failures.

References: #135493

Release note: None

This commit disables deadlock/race runs for TestProxyTracing when running with expiration leases. The main reason is that it consumes resources unnecessarily.

References: #135493

Release note: None

This commit disables follower reads for the test TestProxyTracing. We noticed that sometimes, the test gets slow, and by the time we issue a read request, it's served via follower reads instead of proxying it to the leaseholder.

Fixes: #135493

Release note: None

Release justification: backporting the test deflaking changes

@iskettaneh
kvcoord: print traced query when failing the TestProxyTracing
f7d4b98 
This commit prints the traced query when TestProxyTracing test fails.
This should help with debugging the failures.

References: cockroachdb#135493

Release note: None
@blathers-crl blathers[crl]
Copy link

blathers-crl bot commented Nov 25, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 25, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@iskettaneh
kvcoord: disable deadlock/race for expiration leases TestProxyTracing
39e2cc2 
This commit disables deadlock/race runs for TestProxyTracing when
running with expiration leases. The main reason is that it consumes
resources unnecessarily.

References: cockroachdb#135493

Release note: None
@iskettaneh
kvcoord: Disable follower reads for TestProxyTracing
c43cf5f 
This commit disables follower reads for the test TestProxyTracing. We
noticed that sometimes, the test gets slow, and by the time we issue a
read request, it's served via follower reads instead of proxying it to
the leaseholder.

Fixes: cockroachdb#135493

Release note: None
@iskettaneh iskettaneh marked this pull request as ready for review November 25, 2024 14:32
@iskettaneh iskettaneh requested a review from a team as a code owner November 25, 2024 14:32
@andrewbaptist andrewbaptist self-requested a review November 25, 2024 19:55
andrewbaptist
andrewbaptist approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment •
edited by cockroach-dev-inf
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@iskettaneh
Copy link
Contributor Author

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Nov 25, 2024

👎 Rejected by label

@iskettaneh iskettaneh merged commit 330209c into cockroachdb:release-24.3.0-rc Nov 25, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbaptist andrewbaptist andrewbaptist approved these changes

@arulajmani arulajmani Awaiting requested review from arulajmani

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskettaneh @cockroach-teamcity @andrewbaptist